Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to convert JsTypedArray when converting objects. #1646

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

graphnode
Copy link
Contributor

@graphnode graphnode commented Oct 12, 2023

Also some utility extensions for float typed arrays and added tests for the changes.

Now when using custom type converters or the DefaultTypeConverter JsTypedArrays should be converted correctly to CLR arrays.

Tried to avoid boxing so it uses _arrayElementType to directly convert to the proper array type using the ToNativeArray generic method.

Should close issue #1641.

Also some utility extensions for float typed arrays.
Added tests for changes.
Copy link
Collaborator

@lahma lahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@lahma lahma merged commit e5d60cb into sebastienros:main Oct 13, 2023
3 checks passed
@graphnode graphnode deleted the jstypedarrays-as-arrays branch October 13, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants